Merged
Conversation
If there's no message to be sent there's no activity, so I don't think this was needed. If there's a message it should be pretty lightweight too, I can run 32 processes with a sqlite database and not run into locking issues when sending messages.
Member
Author
|
@jmchilton can you have a look at this ? if there are concerns we could also setup a separate sqlite database for the queue. |
Member
|
Sorry for the delay, I don't catch PRs not on galaxyproject/galaxy - I need a better workflow. I trust you if you say it isn't a problem, happy to merge. Thanks! |
Member
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's no message to be sent there's no activity,
so I don't think this was needed.
If there's a message it should be pretty lightweight too,
I can run 32 processes with a sqlite database and not run into locking
issues when sending messages.