Do not skip Galaxy client build for planemo serve#895
Merged
bgruening merged 11 commits intogalaxyproject:masterfrom Nov 24, 2018
Merged
Do not skip Galaxy client build for planemo serve#895bgruening merged 11 commits intogalaxyproject:masterfrom
planemo serve#895bgruening merged 11 commits intogalaxyproject:masterfrom
Conversation
planemo serve
Member
|
I requested an increased max build time from travis, let's see if they grant it. |
jmchilton
reviewed
Nov 19, 2018
baddf30 to
0caa8dc
Compare
Follow-up on commit ec16ee7 .
…s not exist or is empty. Raise an `Exception` if `--galaxy_root` specifies an existing directory and `--install_galaxy` is set. Remove unused `_shed_tool_conf()` function and `FAILED_TO_FIND_GALAXY_EXCEPTION` constant.
to not rebuild the Galaxy client every time.
Various tests produced the following error: ``` Set $GALAXY_VIRTUAL_ENV to /home/travis/.planemo/gx_venv /bin/sh: 1: if [ -e "$GALAXY_VIRTUAL_ENV" ]; : not found run command exited with return code 127 ``` Introduced in commit 434099e .
Fix wrong tool version in workflow.
Otherwise the `pid_file` is set to the wrong filename, preventing `LocalGalaxyConfig.kill()` from working when running Galaxy under Python 3. Follow-up to galaxyproject#874 .
0caa8dc to
e71791c
Compare
for Python 3 compatibility.
Fix the following traceback:
```
Problem serving Galaxy
Traceback (most recent call last):
File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/serve.py", line 22, in serve
return _serve(ctx, runnables, **kwds)
File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/serve.py", line 43, in _serve
cmd = config.startup_command(ctx, **kwds)
File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/config.py", line 963, in startup_command
host=kwds['host'],
KeyError: 'host'
```
Member
Author
|
Finally green!! 🎉 |
Member
|
Thanks all! |
Member
Author
|
Time for a new Planemo release supporting Galaxy 18.09? |
Member
|
I let you all down on this - sorry :(. Just released this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #845 .
Also, convert an existing
gx_repogit repository from bare to mirror before doing agit remote update.