Skip to content

Do not skip Galaxy client build for planemo serve#895

Merged
bgruening merged 11 commits intogalaxyproject:masterfrom
nsoranzo:serve_rebuild_client
Nov 24, 2018
Merged

Do not skip Galaxy client build for planemo serve#895
bgruening merged 11 commits intogalaxyproject:masterfrom
nsoranzo:serve_rebuild_client

Conversation

@nsoranzo
Copy link
Member

Fix #845 .

Also, convert an existing gx_repo git repository from bare to mirror before doing a git remote update.

@nsoranzo nsoranzo requested a review from mvdbeek November 18, 2018 00:53
@nsoranzo nsoranzo changed the title Do not skip client build for planemo serve Do not skip Galaxy client build for planemo serve Nov 18, 2018
@bgruening
Copy link
Member

I requested an increased max build time from travis, let's see if they grant it.

@nsoranzo nsoranzo force-pushed the serve_rebuild_client branch 3 times, most recently from baddf30 to 0caa8dc Compare November 21, 2018 14:33
…s not exist

or is empty.

Raise an `Exception` if `--galaxy_root` specifies an existing directory and
`--install_galaxy` is set.

Remove unused `_shed_tool_conf()` function and
`FAILED_TO_FIND_GALAXY_EXCEPTION` constant.
to not rebuild the Galaxy client every time.
Various tests produced the following error:
```
Set $GALAXY_VIRTUAL_ENV to /home/travis/.planemo/gx_venv
/bin/sh: 1: if [ -e "$GALAXY_VIRTUAL_ENV" ]; : not found
run command exited with return code 127
```

Introduced in commit 434099e .
Fix wrong tool version in workflow.
Otherwise the `pid_file` is set to the wrong filename, preventing
`LocalGalaxyConfig.kill()` from working when running Galaxy under Python 3.

Follow-up to galaxyproject#874 .
@nsoranzo nsoranzo force-pushed the serve_rebuild_client branch from 0caa8dc to e71791c Compare November 23, 2018 13:28
for Python 3 compatibility.
Fix the following traceback:

```
Problem serving Galaxy
Traceback (most recent call last):
  File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/serve.py", line 22, in serve
    return _serve(ctx, runnables, **kwds)
  File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/serve.py", line 43, in _serve
    cmd = config.startup_command(ctx, **kwds)
  File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/config.py", line 963, in startup_command
    host=kwds['host'],
KeyError: 'host'
```
@nsoranzo
Copy link
Member Author

Finally green!! 🎉

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot @nsoranzo !

@bgruening bgruening merged commit 3ab358e into galaxyproject:master Nov 24, 2018
@bgruening
Copy link
Member

Thanks all!

@nsoranzo nsoranzo deleted the serve_rebuild_client branch November 25, 2018 12:36
@nsoranzo
Copy link
Member Author

Time for a new Planemo release supporting Galaxy 18.09?

@jmchilton
Copy link
Member

I let you all down on this - sorry :(. Just released this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants