increase IO polling interval over time#891
Merged
jmchilton merged 10 commits intogalaxyproject:masterfrom Nov 9, 2018
Merged
Conversation
mvdbeek
reviewed
Nov 8, 2018
nsoranzo
reviewed
Nov 8, 2018
…nson/planemo into increase-polling-interval-overtime
nsoranzo
reviewed
Nov 9, 2018
from a flag to an argument-receiving option
nsoranzo
reviewed
Nov 9, 2018
Member
|
Thanks @martenson for changing it to an int, I wanted to suggest it, but than backed off 😆 |
nsoranzo
approved these changes
Nov 9, 2018
hexylena
approved these changes
Nov 9, 2018
Member
hexylena
left a comment
There was a problem hiding this comment.
Looks good to me. I retract my gitter comments, looks fine even with 5-10s of backoff at each step.
jmchilton
approved these changes
Nov 9, 2018
Member
jmchilton
left a comment
There was a problem hiding this comment.
Perfect, also prefer it as an int - much more general IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces configurable option
--polling_backoff <integer>which, atm, increases polling interval by<integer>second(s) every round. This considerably lowers the load on the target instance when waiting on dataset state changes.xref: galaxyproject/usegalaxy-playbook#164