Fix "planemo conda_search".#826
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom May 16, 2018
Merged
Conversation
There was a change in the galaxy-lib interface it used that broke it, and the underlying CLI seems to require * to do a more SQL-like search now so I've updated that as well. Fixes galaxyproject#824.
nsoranzo
reviewed
May 16, 2018
planemo/commands/cmd_conda_search.py
Outdated
| """ | ||
| conda_context = build_conda_context(ctx, handle_auto_init=True, **kwds) | ||
| conda_context.exec_command("search", [term]) | ||
| args = conda_context._override_channels_args + ["*%s*" % term] |
Member
There was a problem hiding this comment.
This is not going to work on older Conda:
$ ~/miniconda3/bin/conda --version
conda 4.3.33
$ ~/miniconda3/bin/conda search '*samt*'
CommandArgumentError: Failed to compile regex pattern for search: *samt*
regex error: error('nothing to repeat at position 0',)
Last released version of Planemo would work only with Conda 4.3.* or older but my previous fix would only work with 4.4 or newer (thanks to @nsoranzo for the catch). This should now work with any Conda 3 or 4 version I assume - at least the couple I have tried.
nsoranzo
approved these changes
May 16, 2018
Member
Author
|
Thanks for the review and the catch @nsoranzo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a change in the galaxy-lib interface it used that broke it, and the underlying CLI seems to require * to do a more SQL-like search now so I've updated that as well.
Fixes #824.