Skip to content

Use requests.get() when validating http URLs#809

Merged
bgruening merged 1 commit intogalaxyproject:masterfrom
nsoranzo:fix_url_linting
May 6, 2018
Merged

Use requests.get() when validating http URLs#809
bgruening merged 1 commit intogalaxyproject:masterfrom
nsoranzo:fix_url_linting

Conversation

@nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented May 1, 2018

Tested on all dirs in https://github.com/TGAC/earlham-galaxytools and 40 dirs in tools-iuc.

Alternative to #808.

@nsoranzo nsoranzo requested a review from bgruening May 1, 2018 23:47
@nsoranzo nsoranzo mentioned this pull request May 2, 2018
@jmchilton
Copy link
Member

Looks good to me!

@bgruening bgruening merged commit 04f74e9 into galaxyproject:master May 6, 2018
@bgruening
Copy link
Member

Thanks @nsoranzo!

@nsoranzo nsoranzo deleted the fix_url_linting branch May 8, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants