Merged
Conversation
mvdbeek
reviewed
Jun 24, 2017
| def write_targets(self, ctx, target_filename, mulled_targets): | ||
| with open(target_filename, "w") as f: | ||
| contents = ",".join(["%s=%s" % (t.package_name, t.version) for t in mulled_targets]) | ||
| target_strings = list() |
Member
There was a problem hiding this comment.
how about contents = ",".join(["%s=%s" % (t.package_name, t.version) if t.version else "%s" % t.package_name for t in mulled_targets]) ?
Member
Author
There was a problem hiding this comment.
I don't like these large list comprehensions, they are less readable and this section is not performance critical.
Member
|
Is it a good idea to allow this though? Should we not better fix the tools? |
Member
Author
|
I don't think such things are a good idea. But Galaxy allows this so this should work here as well. However, I have on my todo list to enhance planemo lint and if this all is merged I will fix the galaxyp tools. |
Member
|
Sounds good then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles package definitions without a version number: https://github.com/galaxyproteomics/tools-galaxyp/blob/master/tools/peptideshaker/searchgui.xml#L10
might fix: BioContainers/multi-package-containers#329
completely untested ...