Return 0 and a warning if repo has no changes#680
Merged
hexylena merged 1 commit intogalaxyproject:masterfrom May 26, 2017
Merged
Return 0 and a warning if repo has no changes#680hexylena merged 1 commit intogalaxyproject:masterfrom
hexylena merged 1 commit intogalaxyproject:masterfrom
Conversation
martenson
reviewed
May 26, 2017
| ) | ||
| except Exception as e: | ||
| if isinstance(e, bioblend.ConnectionError) and e.status_code == 400 and \ | ||
| e.body == '{"content_alert": "", "err_msg": "No changes to repository."}': |
Member
There was a problem hiding this comment.
I would check only the err_msg here. Content alert has nothing to do with this I think.
Member
Author
There was a problem hiding this comment.
BioBlend returns this ConnectionError exception whose body attribute is the stringified version of the JSON returned by Galaxy. I preferred to be strict to not match other real errors, we can relax this if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #494 .