Fix filter_paths() to not partial match paths#665
Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom Apr 27, 2017
Merged
Fix filter_paths() to not partial match paths#665jmchilton merged 1 commit intogalaxyproject:masterfrom
jmchilton merged 1 commit intogalaxyproject:masterfrom
Conversation
E.g. in galaxyproject/tools-iuc#1278 having 'tools/taxonomy' in `.tt_blacklist` and executing `planemo ci_find_repos --exclude_from .tt_blacklist` wrongly filters out also 'tools/taxonomy_krona_chart'.
Member
|
Sorry about that - thanks for the fix! I guess I should convert those to regex or globs perhaps. |
Member
Author
|
Hopefully we'll remove all tools from the blacklist before that is needed :) |
Member
Author
|
@jmchilton Can you do a release with this included? It's needed for galaxyproject/tools-iuc#1278 . |
Member
|
@nsoranzo 0.40.1 is now available on PyPI. |
Member
Author
|
Thanks @jmchilton, galaxyproject/tools-iuc#1278 is now fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. in galaxyproject/tools-iuc#1278 having 'tools/taxonomy' in
.tt_blacklistand executingplanemo ci_find_repos --exclude_from .tt_blacklistwrongly filters out also 'tools/taxonomy_krona_chart'.