Merged
Conversation
The pep8 tool is now stricter about the blocks it expects imports to be broken up into. This includes local imports.
This error message could have been more useful: $ flake8 --select I100 planemo/commands/cmd_travis_init.py planemo/commands/cmd_travis_init.py:9:1: I100 Import statements are in the wrong order. from planemo should be before from planemo
Member
|
Awesome sauce - thanks a bunch! |
Contributor
Author
|
Travis is happy with the lint checks :) |
Contributor
Author
|
See also flake8-import-order pull request PyCQA/flake8-import-order#98 |
This is to address docstring linting warnings from pydocstyle. Also I am consistently using a multi-line layout even when there is a single entry, and using double quotes. Should close issue galaxyproject#607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes on the master have broken the TravisCI build, this pull request addresses the new PEP8 blank line violations etc