Merged
Conversation
1. Write bioconda recipe 2. clone bioconda repo Add command line utility, to initiate bioconda recipe when given package name. "conda_recipe_init"
…e some of the very lightly used deps here though.
Update requirements for bioc_tool_init work; it'd be nice to eliminat…
typo fix bioconda
…requirements directly
…d_bioc_tool_init, and bioc_tool_builder.
…equirements for bioconda
…l_init Conflicts: requirements.txt
Contributor
|
@jmchilton Can you take a look at why the planemo tests fail? If it just a style issue, i'll fix em. Is there any other blocker? |
Member
Author
|
There are definitely style issues and they should be fixed. There is also a pyaml import issue that prevents tests from loading: There may be more problems also. |
Contributor
|
Will fix now! |
It also takes care of some flake8 issues, along with adding the requirements in the right order. The order of the requirements in flipped in Line 116 where there is a FIXME tag. This is to be dealt with later.
Contributor
|
@jmchilton can you take a look ? |
Contributor
|
@jmchilton Any update on this? |
jmchilton
commented
Nov 11, 2016
|
|
||
| def __str__(self): | ||
| template = '<param type="data" name="{0}" format="{1}" />' | ||
| self.datatype = self.datatype.split(".")[-1] |
Member
Author
There was a problem hiding this comment.
Is this line needed? It seems broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of pull request here #492.