dependency_script - only verify checksum of new downloads#541
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom Aug 18, 2016
Merged
dependency_script - only verify checksum of new downloads#541jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton merged 2 commits intogalaxyproject:masterfrom
Conversation
Contributor
Author
|
Updated the This should solve the potential overhead on my TravisCI usage - the files should be downloaded and the checksum will be verified once only. |
Member
|
Awesome - thanks for the refinement. This seems like a good compromise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refinement to #538 from earlier today, which has been working nicely but makes using
planemo dependency_scriptpainfully slow if you already have the files downloaded and cached because it will verify their checksums.I'm wondering about going further and putting this under a
--verifyswitch (like the commented out one proposed forplanemo shed_lint), since as used on my TravisCI setup the checksums are run twice (once viaplanemo dependency_scriptand again viabash dep_install.sh).