Look for sha256sum checksums during shed_lint#539
Look for sha256sum checksums during shed_lint#539jmchilton merged 2 commits intogalaxyproject:masterfrom
Conversation
|
The failing test case looks legitimate - I'm fine with this change but devteam and iuc repos are going to start failing Travis checks after we merge this right? @martenson, @nsoranzo, @bgruening, @erasche are we okay with that? |
|
👍 I want to know if my downloads are failing hash checks. Edit: oh, does this fail things with a missing sha256? |
|
I did the exact same steps in my brain as @erasche did. 👍 |
|
👍 for me, we will fix travis if this is the case. Nice change Peter! |
|
Copy and paste error in the test cases, one of the checksums is the wrong one... |
Looks at the download_by_url and download_file actions only, missing sha256sum is a warning, bad sha256sum is an error (e.g. not 64 characters, or non-hex characters present). A future --verify switch could download the file and confirm the checksum matches.
|
Awesome sauce - thanks! This didn't make the 0.28.0 cut - but it will be 0.29.0. Is there urgency - I can do a release if so? |
|
Thanks John - there's no rush from my personal perspective. |
Looks at the
download_by_urlanddownload_fileactions only, missing sha256sum is a warning, bad sha256sum is an error (e.g. not 64 characters, or non-hex characters present).A future
--verifyswitch could download the file and confirm the checksum matches.TODO: Test case with a bad sha256sum entry (e.g. extra char)