Update pip and setuptools on TravisCI; fix travis_init#521
Merged
bgruening merged 2 commits intogalaxyproject:masterfrom Jul 22, 2016
Merged
Update pip and setuptools on TravisCI; fix travis_init#521bgruening merged 2 commits intogalaxyproject:masterfrom
bgruening merged 2 commits intogalaxyproject:masterfrom
Conversation
Closes galaxyproject#520 where the dependency chain planemo, cwltool, rdflib, html5lib failed as that needed setuptools version 18.5 or later.
This was a recent mistake of mine, I must not have have the git pre-commit hook installed on the machine I used as that caught both points: planemo/commands/cmd_travis_init.py:49:1: E302 expected 2 blank lines, found 1 planemo/commands/cmd_travis_init.py:81:9: F821 undefined name 'warning'
Member
|
Upgrading |
Contributor
Author
|
Possibly updating setuptools only is enough right now, but I've been bitten by an old pip before with other TravisCI setups, so this seems a sensible precautionary measure. |
Member
|
CWL errors again. I think it's fine to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #520 by explicitly updating pip and setuptools before installing planemo.
Also fixes a regression I introduced recently in 364fec2 (typo in function name)