Skip to content

Change 127.0.0.1 to 0.0.0.0 to allow serving in docker container.#288

Closed
chambm wants to merge 1 commit intogalaxyproject:masterfrom
chambm:chambm-non-loopback-host-address
Closed

Change 127.0.0.1 to 0.0.0.0 to allow serving in docker container.#288
chambm wants to merge 1 commit intogalaxyproject:masterfrom
chambm:chambm-non-loopback-host-address

Conversation

@chambm
Copy link
Contributor

@chambm chambm commented Sep 2, 2015

My docker container doesn't have a GUI. Nor for that matter does my Linux host. So I'm connecting from my Windows box, through a Linux VM, to the Docker container hosting 'planemo serve'. I had to make this change for it to work properly.

My docker container doesn't have a GUI. Nor for that matter does my Linux host. So I'm connecting from my Windows box, through a Windows VM, to the Docker container hosting 'planemo serve'. I had to make this change for it to work properly.
@jmchilton
Copy link
Member

I think I don't want to accept this as is. I worry about binding an unsecured Galaxy to 0.0.0.0 by default. I understand the need for it but I would rather make it configurable - by adding a --host parameter to anything to hosts Galaxy, and falling back to default_galaxy_host in ~/.planemo.yml if that is not specified, and then falling back to 127.0.0.1.

Let me know if this sounds like an acceptable path forward and I can try to make those changes.

@chambm
Copy link
Contributor Author

chambm commented Sep 10, 2015

Yep, that sounds better. I went for the expedient solution because I
wasn't familiar with the code. :)

-Matt

On 9/10/2015 9:09 AM, John Chilton wrote:

I think I don't want to accept this as is. I worry about binding an
unsecured Galaxy to 0.0.0.0 by default. I understand the need for it
but I would rather make it configurable - by adding a |--host|
parameter to anything to hosts Galaxy, and falling back to
|default_galaxy_host| in |~/.planemo.yml| if that is not specified,
and then falling back to |127.0.0.1|.

Let me know if this sounds like an acceptable path forward and I can
try to make those changes.


Reply to this email directly or view it on GitHub
#288 (comment).

@jmchilton
Copy link
Member

Superseded by #301 which includes this commit.

@jmchilton jmchilton closed this Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants