Accept completed as terminal invocation state#1615
Merged
mvdbeek merged 5 commits intogalaxyproject:masterfrom Feb 18, 2026
Merged
Accept completed as terminal invocation state#1615mvdbeek merged 5 commits intogalaxyproject:masterfrom
mvdbeek merged 5 commits intogalaxyproject:masterfrom
Conversation
Galaxy can return a 'completed' invocation state meaning the workflow is fully scheduled and all jobs have finished. Update all places that check for 'scheduled' to also accept 'completed': - invocation_state_terminal() in api.py - Success check in activity.py invocation_to_run_response - was_successful property in GalaxyWorkflowRunResponse - Error detection in polling.py workflow_in_error_message - Step state counting in progress.py for display https://claude.ai/code/session_01LqVSyh3oWZ4JXngfULiyoA
Replace inline ("scheduled", "completed") tuple with a named constant,
and derive INVOCATION_TERMINAL_STATES from success + error state tuples.
https://claude.ai/code/session_01LqVSyh3oWZ4JXngfULiyoA
- tox.ini: Replace 2205 env with 231 and add 250 env - CI: Update matrix to test against gx-231 and gx-250 instead of gx-2205 and gx-231 - Tests: Update skip conditions from release_22.05 to release_23.1 - activity.py: Update version reference in comment Also includes formatting fixes from make format. https://claude.ai/code/session_01LqVSyh3oWZ4JXngfULiyoA
nsoranzo
approved these changes
Feb 17, 2026
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
717a17f to
4dcb7dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And drop tests against 22.05