Skip to content

Move deploy to a separate workflow for trusted publishing#1608

Merged
mvdbeek merged 1 commit intogalaxyproject:masterfrom
nsoranzo:trusted_publishing
Feb 3, 2026
Merged

Move deploy to a separate workflow for trusted publishing#1608
mvdbeek merged 1 commit intogalaxyproject:masterfrom
nsoranzo:trusted_publishing

Conversation

@nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Feb 3, 2026

@mvdbeek mvdbeek merged commit d0fe1da into galaxyproject:master Feb 3, 2026
0 of 14 checks passed
Comment on lines -88 to -90
- uses: actions/setup-node@v6
with:
node-version: '18.12.1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvdbeek This was added in 1dfa3e6 but I don't think it's needed?
I've dropped it in the new workflow.

@nsoranzo nsoranzo deleted the trusted_publishing branch February 3, 2026 16:45
@@ -0,0 +1,38 @@
name: Deploy
on: [push, pull_request]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gonna fail unless the history.rst is already written correctly. I'd only run this on release tags

Copy link
Member Author

@nsoranzo nsoranzo Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this failed because HISTORY.rst is actually broken: d49df48#diff-e2de3cbc57ab9b097fca7d7c444c094ba3c1d4ee92b36d972d0d9d49669436ccR12

Seems a good thing to check without waiting for a release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ... but how's this happening ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants