Some refactoring and fixes for handing of conda packages#1592
Merged
nsoranzo merged 11 commits intogalaxyproject:masterfrom Dec 19, 2025
Merged
Some refactoring and fixes for handing of conda packages#1592nsoranzo merged 11 commits intogalaxyproject:masterfrom
nsoranzo merged 11 commits intogalaxyproject:masterfrom
Conversation
9656eee to
97e7fec
Compare
97e7fec to
2328f8e
Compare
in planemo.mulled.conda_to_mulled_targets essentially the build info is stripped from the conda targets. that is - conda target = (name, version, build) - mulled target = (name, version) since the build information has not been determined so far - galaxyproject/galaxy#21481, - galaxyproject/galaxy#18522 the distinction seems to make no sense.
which properly parses versions
2328f8e to
cd5f04d
Compare
nsoranzo
reviewed
Dec 17, 2025
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
bernt-matthias
commented
Dec 17, 2025
4ac673e to
fa76a27
Compare
95555f5 to
408d638
Compare
nsoranzo
reviewed
Dec 18, 2025
337ae2d to
cc21892
Compare
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
cc21892 to
30694f6
Compare
nsoranzo
reviewed
Dec 19, 2025
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
bernt-matthias
commented
Dec 19, 2025
nsoranzo
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit descriptions. Mainly
conda_to_mulled_targetsandcollect_mulled_target_listswhich were used to set thebuildattribute ofCondaTargets toNone, which is not needed:Nonev2_image_namefunction ignores the package build info anyway - we just need to construct theCondaTargets properlytarget_str_to_targetsfromgalaxy.tool-utilwhich properly parses builds from the version (only affects 2planemo conda...commands)