Terminate polling if we can't advance invocation#1547
Merged
mvdbeek merged 1 commit intogalaxyproject:masterfrom Jun 20, 2025
Merged
Terminate polling if we can't advance invocation#1547mvdbeek merged 1 commit intogalaxyproject:masterfrom
mvdbeek merged 1 commit intogalaxyproject:masterfrom
Conversation
jmchilton
reviewed
Jun 20, 2025
| # This is a tricky issue, because we might be waiting to schedule a new step whose inputs are paused. | ||
| # Unlikely that this will ever be unpaused, so we also consider the "ready" invocation state and the presence of paused jobs as terminal. | ||
| # We might want to tweak the state in Galaxy if we pause jobs because of input errors, so that this hack won't be rquired. | ||
| return invocation_state_terminal(self.invocation_state) or self.invocation_state == "ready" and self.num_paused and self.num_errors |
Member
There was a problem hiding this comment.
This vaguely makes sense - definitely seems like something we need to cleanup Galaxy side long term. Maybe we should pause workflows with paused jobs.
jmchilton
approved these changes
Jun 20, 2025
9dc6764 to
5b6df72
Compare
because all jobs are terminal and we have paused jobs.
5b6df72 to
2a59f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because all jobs are terminal and we have paused jobs.