Fix autoupdate for workflows with overlapping tool updates#1452
Fix autoupdate for workflows with overlapping tool updates#1452mvdbeek merged 4 commits intogalaxyproject:masterfrom
Conversation
3906a83 to
e49b080
Compare
|
I would really appreciate it if we didn't need one instance per workflow. We then check if any tool has actually been upgraded. That means it will also work for local non-TS tools (e.g. built-in tools and converters). The cost of running the refactoring action is minimal, compared to one instance per workflow. |
This reverts commit e49b080.
Would we need to implement this? Or is this already included? |
mvdbeek
left a comment
There was a problem hiding this comment.
Thanks a lot @bernt-matthias, added a test for this. Let's merge if it passes
An attempt to solve the problem that the workflow autoupdate does not update all workflows in a dir.
I think the problem occurs if the tool set of the workflows overlaps (e.g. galaxyproject/iwc#422).
The symptom that is fixed by my change is that
config.updated_reposgets empty for some workflows which are therefore skipped.I guess a cleaner way to fix this might be to uninstall all tools again after a workflow was processed?