Fix parsing of training metadata.yaml files#1439
Fix parsing of training metadata.yaml files#1439nsoranzo merged 1 commit intogalaxyproject:masterfrom
metadata.yaml files#1439Conversation
1e05c58 to
56806d3
Compare
bernt-matthias
left a comment
There was a problem hiding this comment.
Do we test or should we somehow test that the generated yaml file is valid (wrt to a schema)? Does GTN has one? Should we request one?
I kind of do not understood why those internal (variable) names need to be renamed instead of just changing the display or giving a proper definition. But this is a different question.
bernt-matthias
left a comment
There was a problem hiding this comment.
Apart from this more general question the PR seems fine.
the gtn has one, yes. but we are also considering alternative implementations that would be more integrated into the GTN, so, i'm not sure if it's worth the effort. the schema is here: https://github.com/galaxyproject/training-material/blob/main/bin/schema-tutorial.yaml, but it does some non-standard things (namely replacing keywords like We could emit a proper schema at an api endpoint that would be up-to-date if need be, just name the preferred format.
for me it would've been equivalent, yes, but i can see wanting to be sure all references are updated correctly. |
Indeed, keeping variable names synced with the corresponding references was easy enough. |
Fix #1415 .