Fix running workflow tests when there are multiple tests#1407
Merged
mvdbeek merged 3 commits intogalaxyproject:masterfrom Nov 16, 2023
Merged
Fix running workflow tests when there are multiple tests#1407mvdbeek merged 3 commits intogalaxyproject:masterfrom
mvdbeek merged 3 commits intogalaxyproject:masterfrom
Conversation
|
Looks good to me. |
|
Failed lint is in planemo/engine/interface.py: |
e8828fa to
c3ee580
Compare
Otherwise the lambda runs with the last test case only.
c3ee580 to
cf90306
Compare
nsoranzo
reviewed
Nov 14, 2023
| """Test testing a simple YAML workflow with Galaxy.""" | ||
| with self._isolate(): | ||
| with self._isolate() as test_dir: | ||
| random_lines = os.path.join(PROJECT_TEMPLATES_DIR, "demo", "randomlines.xml") |
Member
There was a problem hiding this comment.
Not related, but why is the random_lines1 tool added as --extra_tools below (and in another test), even if the tool is not used in the wf1.gxwf.yml workflow?
Member
Author
There was a problem hiding this comment.
maybe to check that multiple --extra_tools work ?
nsoranzo
reviewed
Nov 14, 2023
Member
Author
|
Test error seems unrelated, quay.io timing out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also re-uses the galaxy instance for additional test.
Fixes galaxyproject/iwc#274 (comment)