Skip to content

Pin allure-python-commons version#1356

Closed
tuncK wants to merge 2 commits intogalaxyproject:masterfrom
tuncK:allure
Closed

Pin allure-python-commons version#1356
tuncK wants to merge 2 commits intogalaxyproject:masterfrom
tuncK:allure

Conversation

@tuncK
Copy link

@tuncK tuncK commented Mar 1, 2023

The new release of v. 2.13.0 makes planemo crash:

...
File "/home/ubuntu/miniconda3/envs/planemo/lib/python3.8/site-packages/planemo/reports/allure.py", line 19, in
from allure_commons.utils import (
ImportError: cannot import name 'escape_non_unicode_symbols' from 'allure_commons.utils' (/home/ubuntu/miniconda3/envs/planemo/lib/python3.8/site-packages/allure_commons/utils.py)

Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@mvdbeek mvdbeek enabled auto-merge March 1, 2023 10:02
@nsoranzo
Copy link
Member

nsoranzo commented Mar 1, 2023

escape_non_unicode_symbols is a Python2-compatibility utility function, which should be unneeded nowadays. I'd rather remove it from Planemo that pin allure-python-commons .

@nsoranzo
Copy link
Member

nsoranzo commented Mar 1, 2023

We have merged the alternative PR #1357, thanks @tuncK for reporting the issue and opening this!

@nsoranzo nsoranzo closed this Mar 1, 2023
auto-merge was automatically disabled March 1, 2023 15:59

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants