Merged
Conversation
thereby datasets get different IDs in different test sessions this will make tests more robust in the long run. currently datasets get the same ID in each test (containing the same set of tests). since in weekly CI tests this set is different than in PR tests tools may fail in weekly tests that just were successful in PR tests.
mvdbeek
approved these changes
Jan 30, 2023
Member
|
Thank you! Odd that didn't get used as default ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thereby datasets get different IDs in different test sessions
this will make tests more robust in the long run. currently datasets get the same ID in each test (containing the same set of tests). since in weekly CI tests this set is different than in PR tests tools may fail in weekly tests that just were successful in PR tests.