Skip to content

Deprecate introduction slides folder#1344

Merged
nsoranzo merged 1 commit intomasterfrom
deprecate-training-slides
Jan 12, 2023
Merged

Deprecate introduction slides folder#1344
nsoranzo merged 1 commit intomasterfrom
deprecate-training-slides

Conversation

@hexylena
Copy link
Member

We have decided it is no longer necessary, and will be mixed in with regular materials.

@nsoranzo
Copy link
Member

nsoranzo commented Jan 12, 2023

Can you please also update the tests, e.g. tests/test_training_topic.py mentions slides_folder

@hexylena
Copy link
Member Author

Yes, of course. I didn't know what all was tested so was just waiting for GHA to fail and let me know :)

We have decided it is no longer necessary, and will be mixed in with regular materials.
@hexylena hexylena force-pushed the deprecate-training-slides branch from 28c69b9 to 1c9893c Compare January 12, 2023 10:48
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hexylena !

@nsoranzo nsoranzo merged commit c40a036 into master Jan 12, 2023
@nsoranzo nsoranzo deleted the deprecate-training-slides branch January 12, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants