Fix for_paths when path is directory of tools#1312
Merged
mvdbeek merged 6 commits intogalaxyproject:masterfrom Nov 2, 2022
Merged
Fix for_paths when path is directory of tools#1312mvdbeek merged 6 commits intogalaxyproject:masterfrom
for_paths when path is directory of tools#1312mvdbeek merged 6 commits intogalaxyproject:masterfrom
Conversation
We'd previously return the directory type runnable, but with 0.75.1 we're expanding the directory into a list of workflow or tool runnables. This makes it match the return type annotation. Fixes galaxyproject#1311 (comment)
5d2a5c1 to
162094d
Compare
Member
|
That means we should also drop the |
Member
Author
|
I guess we can also drop the return_all argument ... |
e7e7aff to
48b2e74
Compare
nsoranzo
reviewed
Nov 2, 2022
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
nsoranzo
reviewed
Nov 2, 2022
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
nsoranzo
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd previously return the directory type runnable, but with 0.75.1 we're expanding the directory into a list of workflow or tool runnables.
This makes it match the return type annotation.
Fixes #1311