Fix printing planemo test logs#1299
Merged
mvdbeek merged 3 commits intogalaxyproject:masterfrom Oct 20, 2022
Merged
Conversation
4c53dd2 to
2fe14f7
Compare
jdavcs
approved these changes
Oct 19, 2022
Member
|
the failure may be related |
2fe14f7 to
6750db5
Compare
Member
Author
|
Yep, had to use the with statement in cmd_serve.py as well. |
martenson
reviewed
Oct 19, 2022
martenson
reviewed
Oct 19, 2022
We were quitting the context manager scope too early, so the print threads would stop too early.
6750db5 to
ad9253f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were quitting the context manager scope too early, so the print threads would stop too early.
I think this is the last fix after which I would create a new planemo release.