Skip to content

Fix workflow test when input is optional but also workflow output#1297

Merged
mvdbeek merged 4 commits intogalaxyproject:masterfrom
mvdbeek:fix_workflow_test_input_optional
Oct 25, 2022
Merged

Fix workflow test when input is optional but also workflow output#1297
mvdbeek merged 4 commits intogalaxyproject:masterfrom
mvdbeek:fix_workflow_test_input_optional

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 19, 2022

i.e:

        "0": {
            "annotation": "",
            "content_id": null,
            "errors": null,
            "id": 0,
            "input_connections": {},
            "inputs": [],
            "label": null,
            "name": "Input dataset",
            "outputs": [],
            "position": {
                "left": 0,
                "top": 0.0
            },
            "tool_id": null,
            "tool_state": "{\"optional\": true, \"tag\": \"\"}",
            "tool_version": null,
            "type": "data_input",
            "uuid": "e6301247-43c4-452d-a3d1-8e140c3945fd",
            "workflow_outputs": [
                {
                    "label": "optional_output",
                    "output_name": "output",
                    "uuid": "6b333ea9-6c5c-4823-be37-be9a36112c39"
                }
            ]

To enable testing this workflow without jobs we now poll on the invocation jobs instead of the history jobs (5cb3de0) after the invocation has finished scheduling.

Also includes a better error message when the uploads fails and removes an old workaround that isn't necessary anymore.

@mvdbeek mvdbeek requested a review from jmchilton October 19, 2022 15:17
@mvdbeek mvdbeek merged commit 808f9b7 into galaxyproject:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants