Pre-create expected output file on disk#1276
Merged
mvdbeek merged 1 commit intogalaxyproject:masterfrom Oct 19, 2022
Merged
Conversation
Member
|
An empty file is better than no file? I'm confused by this but I trust you. |
jmchilton
approved these changes
Oct 10, 2022
Member
Author
|
This became necessary when we started downloading all workflow outputs and then comparing the outputs to expectations... i don't think this is actually the proper fix, I'm not sure what the right fix is. Maybe we shouldn't be downloading all outputs in test mode and instead follow the verify pattern from galaxy-tool-util more closely? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should "fix"
In @Delphine-L's https://github.com/galaxyproject/iwc/actions/runs/3176857778/jobs/5176648484