Document the use of mandatory macro parameters and add named macro tokens#1212
Merged
jmchilton merged 6 commits intogalaxyproject:masterfrom Sep 9, 2022
Merged
Conversation
nsoranzo
reviewed
Jan 12, 2022
nsoranzo
approved these changes
Jan 12, 2022
5 tasks
mvdbeek
reviewed
Jan 14, 2022
Collaborator
Author
|
I hope that I have addressed all comment. Just had the idea that one could allow content to |
72dd9dc to
287de30
Compare
learned while working on galaxyproject/galaxy#13152
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
that might be added here galaxyproject/galaxy#13152
Collaborator
Author
|
Hey @nsoranzo there were quite a few commits after your approval. Are you still OK with merging? |
nsoranzo
reviewed
Jul 26, 2022
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
nsoranzo
approved these changes
Jul 27, 2022
Member
|
Sorry for the delay on the merge - very nice work. Thank you both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
learned while working on galaxyproject/galaxy#13152