Use WorkflowId rather than StoredWorkflowId when autoupdating subworkflows#1205
Merged
bgruening merged 1 commit intogalaxyproject:masterfrom Nov 15, 2021
Merged
Use WorkflowId rather than StoredWorkflowId when autoupdating subworkflows#1205bgruening merged 1 commit intogalaxyproject:masterfrom
bgruening merged 1 commit intogalaxyproject:masterfrom
Conversation
Member
Yep, that's the problem |
mvdbeek
approved these changes
Nov 11, 2021
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried autoupdating a couple of workflows containing subworkflows today against usegalaxy.eu and it failed, because a GET to
api/workflows/workflow_idreturns subworkflow WorkflowIds rather than StoredWorkflowIds. When submitting that ID to the API to get the subworkflow details, theinstanceparam needs to be set to True.I was a bit surprised why the test doesn't catch this, because it contains a subworkflow. I think the reason is that on fresh Galaxy instances the Workflow and StoredWorkflow ID is the same for the first workflow uploaded.