Allways use random id_secret for testing#1198
Merged
bgruening merged 6 commits intogalaxyproject:masterfrom Nov 15, 2021
Merged
Allways use random id_secret for testing#1198bgruening merged 6 commits intogalaxyproject:masterfrom
bgruening merged 6 commits intogalaxyproject:masterfrom
Conversation
Member
|
I don't think we need an option for this, we should just always generate a random |
Collaborator
Author
Good idea. Then we also need no change to the planemo-ci-action. |
4df9b0a to
adef5e4
Compare
jmchilton
approved these changes
Nov 4, 2021
adef5e4 to
e58d26a
Compare
instead of requiring the user to do it on its own
This reverts commit 22fc78f.
Collaborator
Author
|
Thanks for your approval @jmchilton . After rebasing also tests seem to pass now. |
Member
|
Thanks @bernt-matthias! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix galaxyproject/planemo-ci-action#18
As far as I can see this is then set as
'GALAXY_CONFIG_OVERRIDE_ID_SECRET'in the env over here:planemo/planemo/galaxy/config.py
Line 514 in 2c3c594
--id_secreton the CLI, ie. the user needs to generate the secret on its own.I'm not 100% sure if Galaxy actually uses the env variable .. any idea how to test this?