Select refgenie config based on Galaxy version#1187
Merged
mvdbeek merged 2 commits intogalaxyproject:masterfrom Sep 21, 2021
Merged
Select refgenie config based on Galaxy version#1187mvdbeek merged 2 commits intogalaxyproject:masterfrom
mvdbeek merged 2 commits intogalaxyproject:masterfrom
Conversation
6dc6b6e to
f40faf1
Compare
Collaborator
bernt-matthias
left a comment
There was a problem hiding this comment.
Wondering if we should setup a test for this, e.g. something like the mock planemo run during the setup stage in the IUC CI vs the latest Galaxy release.
One might also parametrize the planemo to use (fork and branch) in the CI action .. but this might be overkill.
Apart from this it looks good to me ..
if available. Else default to current version (0.4).
0c8d673 to
0768932
Compare
bernt-matthias
approved these changes
Sep 21, 2021
jmchilton
approved these changes
Sep 21, 2021
Member
|
Thanks for working through all this complexity. I wish we were deriving more benefit from refgenie. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if available. Else default to current version (0.4).
Fixes https://github.com/galaxyproject/tools-iuc/runs/3654913135?check_suite_focus=true