Fix --shed_install for gxformat2 workflows#1182
Merged
jmchilton merged 4 commits intogalaxyproject:masterfrom Jul 22, 2021
Merged
Fix --shed_install for gxformat2 workflows#1182jmchilton merged 4 commits intogalaxyproject:masterfrom
jmchilton merged 4 commits intogalaxyproject:masterfrom
Conversation
Member
|
Do we need to add a test for this? I couldn't find a Format 2 workflow with |
jmchilton
reviewed
Jul 21, 2021
| with open(path, "r") as f: | ||
| workflow = yaml.safe_load(f) | ||
|
|
||
| tools = workflow.get("tools", []) |
Member
There was a problem hiding this comment.
I liked the idea of the workflows also serving as ephemeris installable entities - so the workflow could just have a list of repos to install. I guess that never made it into the schema though 🤔.
Member
Author
There was a problem hiding this comment.
We should make the tool ids resolvable, then we don't need this duplication (or the tool_shed_repositories entry in general) and we could finally get away from the repository concept 🙏.
54cdd39 to
23f1abf
Compare
I don't think these were every used and they're probably not useful now.
23f1abf to
cae73b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.