Improve dockstore_init#1177
Merged
jmchilton merged 3 commits intogalaxyproject:masterfrom Jun 23, 2021
Merged
Conversation
c00ece0 to
5542ae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File paths seem to necessarily start with
/, see https://docs.dockstore.org/en/develop/getting-started/github-apps/github-apps.html#workflow-yml-file and planemo's own .dockstore.yml test files.planemo workflow_lintalready checks for that inplanemo/planemo/workflow_lint.py
Line 213 in 960b61e
That means the .dockstore.yml file generated with the fix passes
planemo workflow_lint, which I've used as the test case here.Also adds the testParameterFiles array if a test file is present.