Fix virtualenv mess maybe#1145
Merged
mvdbeek merged 7 commits intogalaxyproject:masterfrom Feb 25, 2021
Merged
Conversation
And when I say today it probably has been plagueing us for a long time. The workaround was because of pypa/virtualenv#845, which seem to have been fixed in a "rewrite" branch. MIght fix galaxyproject#1088 and galaxyproject#1078.
Member
|
I've spent so many hours banging my head futilely at this issue - I will be so grateful if this works! |
942c3ef to
d2d0a5b
Compare
Member
Author
|
I did see some really odd behavior locally, and that fixes it, but I admit I'm flying blind here :/. Ideally we'd add some testing with conda, brew and pyvenv to be sure |
nsoranzo
reviewed
Feb 24, 2021
nsoranzo
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.