Some fixes for workflow_job_init and workflow_test_init#1101
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom Dec 11, 2020
Merged
Some fixes for workflow_job_init and workflow_test_init#1101jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton merged 2 commits intogalaxyproject:masterfrom
Conversation
Member
simonbray
commented
Dec 2, 2020
- Recognize the input types as specified by gxformat2 here: https://github.com/galaxyproject/gxformat2/blob/master/gxformat2/model.py#L66
- Add parameters
- Add a more helpful error message for unlinted workflows
87176fc to
81a3605
Compare
Member
|
Can you please add a test, so we do not regress here anymore? Thanks. |
Member
Author
There is a test already, but you are right, I need to make it stricter. Also, these commands don't work yet with workflow IDs, it would be good to get that working. |
Member
Author
I will leave this for now. |
Member
|
Sorry for missing this! Feel free to ping me on these Planemo PRs for potentially quicker turn around. |
Member
Author
|
No worries, thanks for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.