Allow testing dir of workflows#1095
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom Feb 13, 2021
Merged
Conversation
056264c to
18a41d3
Compare
Collaborator
bernt-matthias
left a comment
There was a problem hiding this comment.
Just a few comments on my attempt to merge.
planemo/engine/interface.py
Outdated
| run_response = self._run(runnable, job_path) | ||
| return run_response | ||
| # TODO where is path comining from? | ||
| for runnable in for_path(path): |
Collaborator
There was a problem hiding this comment.
Neither path nor for_path are defined here. Can you give me a few hints how to solve this?
| kwds["workflows_from_path"] = True | ||
|
|
||
| # TODO this foo seems unimported (also not sure if works when called with id) | ||
| runnables = for_path(workflow_identifier) |
Collaborator
There was a problem hiding this comment.
Before my merge for_path (which misses an import I guess) was called on workflow_path, but recently all workflow_path were replaced by workflow_identifier .. so this is likely broken with my commit.
Member
Author
There was a problem hiding this comment.
Ah, yeah, this was changed even before that. I think I found a less intrusive way to do this now.
4a73b76 to
007bdf0
Compare
007bdf0 to
8d67a31
Compare
8d67a31 to
97a9134
Compare
simonbray
approved these changes
Feb 12, 2021
jmchilton
approved these changes
Feb 12, 2021
Co-authored-by: Simon Bray <32272674+simonbray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.