Skip to content

Add workflow_upload command#1091

Merged
jmchilton merged 8 commits intogalaxyproject:masterfrom
mvdbeek:ci_find_workflows
Oct 15, 2020
Merged

Add workflow_upload command#1091
jmchilton merged 8 commits intogalaxyproject:masterfrom
mvdbeek:ci_find_workflows

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 5, 2020

planemo workflow_upload will update or create a github repository with the contents of a directory that contains a workflow.
Every upload will create a new release. Workflow versions are taken from the workflow files.

Also moves from hub to gh and makes planemo ci_find_repos return directories with workflows.

TODO:

  • Check if version already exists / handle empty diff ?
  • --force that will override existing version
  • Handle deleted files (remove everything in work dir, then copy ?)


unique_paths = set(os.path.relpath(p, cwd) for p in raw_paths)
if diff_paths is not None:
new_unique_paths = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have understood the purpose here. Was this meant to filter our paths in diff_paths that are not within raw_paths ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was (and should remain) the intersection of unique_paths (i.e. the tool or repo specified by path by the user) and diff_paths (the list of files or directories changed in Git).
Sorry I missed this at the time, should be fixed by #1127 .

@mvdbeek mvdbeek force-pushed the ci_find_workflows branch 8 times, most recently from 2068dea to 9c9c639 Compare October 12, 2020 14:10
@mvdbeek mvdbeek changed the title Add .dockstore.yml to files considered for ci_find_repos Add workflow_upload command Oct 13, 2020
``planemo workflow_upload`` will update or create a github repository
with the contents of a directory that contains a workflow.
Every upload will create a new release.
Workflow versions are taken from the workflow files.
@mvdbeek mvdbeek force-pushed the ci_find_workflows branch 2 times, most recently from 8a37d18 to ac27888 Compare October 14, 2020 20:44
@mvdbeek mvdbeek force-pushed the ci_find_workflows branch 2 times, most recently from f584e0e to c877384 Compare October 15, 2020 08:09
@mvdbeek mvdbeek marked this pull request as ready for review October 15, 2020 12:13
@mvdbeek
Copy link
Member Author

mvdbeek commented Oct 15, 2020

I think this is ready for review!

@jmchilton jmchilton merged commit 72af7c1 into galaxyproject:master Oct 15, 2020
@jmchilton
Copy link
Member

Simply amazing!

@bgruening
Copy link
Member

Wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants