Changes to update_test_data testing mode#1079
Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom Oct 2, 2020
Merged
Conversation
Member
|
👍 I guess this will also be useful for automatic update PRs. |
Member
|
Nice one, thanks @simonbray - that seems like a logical fix to me - will take a look shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to improve the 'update test data' mode to make it a bit more user-friendly, see #1070. Ping @fubar2.
The currently behaviour is that the
--update_test_dataflag just causes the job_output_files dir to be copied back to the test dir. So the test results confusingly do not actually relate to the new updated data at all. Furthermore, if tests fail, the command needs to be rerun to check that they work with the new data.New behaviour in this PR when the
--update_test_dataflag is used:Test data were updated and tests were rerun.All x test(s) executed passed. Therefore, no test data were updated.