Fixes for CLI when external_galaxy is used as the engine#1072
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom Sep 1, 2020
Merged
Fixes for CLI when external_galaxy is used as the engine#1072jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton merged 2 commits intogalaxyproject:masterfrom
Conversation
simonbray
commented
Aug 28, 2020
planemo/galaxy/config.py
Outdated
|
|
||
| def _install_workflow(self, runnable): | ||
| if self._kwds.get("shed_install"): | ||
| if self._kwds.get("shed_install") and self._kwds.get("engine") != "external_galaxy": |
Member
Author
There was a problem hiding this comment.
or maybe something like: (self._kwds.get("engine") != "external_galaxy" or self._kwds.get("galaxy_admin_key"))
so it would still be possible to run shed_install on an external galaxy instance, as long as the admin key was specified.
Member
There was a problem hiding this comment.
so it would still be possible to run shed_install on an external galaxy instance, as long as the admin key was specified.
I think this is an important use-case, e.g. for a Galaxy test server. Or a training instance that will be setup.
Member
|
Thanks for the fixes - these seem great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor changes:
--galaxy_urlis specified, the engine should beexternal_galaxyby default without this having to be additionally specified.