Make splitting job and test files optional#1064
Merged
bgruening merged 1 commit intogalaxyproject:masterfrom Aug 5, 2020
Merged
Make splitting job and test files optional#1064bgruening merged 1 commit intogalaxyproject:masterfrom
bgruening merged 1 commit intogalaxyproject:masterfrom
Conversation
I think that makes writing tests easier and I think @bgruening agrees (galaxyproject/training-material#2021 (comment))
mvdbeek
reviewed
Aug 5, 2020
| if split_test: | ||
| job_output = new_workflow_associated_path(workflow_path, suffix="job1") | ||
| if not can_write_to_path(job_output, **kwds): | ||
| ctx.exit(1) |
Member
There was a problem hiding this comment.
Does that print some information about why this failed ?
Member
Author
There was a problem hiding this comment.
I think so:
error("%s already exists, exiting." % path)
Member
Author
There was a problem hiding this comment.
It'd be good to also check the directory exists and is writable... but yeah...
mvdbeek
approved these changes
Aug 5, 2020
Member
|
Indeed, I think as the default behavior this is better. For power users, the split one is probably best. I like it! Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that makes writing tests easier and I think @bgruening agrees (galaxyproject/training-material#2021 (comment))