Add mypy type checking.#1060
Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom Aug 4, 2020
Merged
Conversation
b9d5221 to
7ec4840
Compare
Member
|
🥇 this is awesome. @jmchilton can you outline how you want to proceed with mypy maybe we can help. |
Member
Author
|
I don't know 🤷♂️ - this isn't a real priority just something I was hacking on between rounds of fighting with CI on actually important PRs. I think what is here right now is okay and will catch a few errors here and there and will encourage best practices to get us ready for typing. If I had to guess on another big next task it would probably be to include type annotations with galaxy-util, galaxy-tool-util, and bioblend. I had to disable import checking because a variety of libraries don't support it - so starting at the bottom of the dependency chain and working up would probably be the next step? |
nsoranzo
reviewed
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various code cleanups (dropping Python 2 compat. mostly) to be enable this.