Skip to content

Add mypy type checking.#1060

Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton:mypy
Aug 4, 2020
Merged

Add mypy type checking.#1060
jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton:mypy

Conversation

@jmchilton
Copy link
Member

Various code cleanups (dropping Python 2 compat. mostly) to be enable this.

@jmchilton jmchilton force-pushed the mypy branch 2 times, most recently from b9d5221 to 7ec4840 Compare August 4, 2020 03:45
@bgruening
Copy link
Member

🥇 this is awesome. @jmchilton can you outline how you want to proceed with mypy maybe we can help.

@jmchilton
Copy link
Member Author

I don't know 🤷‍♂️ - this isn't a real priority just something I was hacking on between rounds of fighting with CI on actually important PRs.

I think what is here right now is okay and will catch a few errors here and there and will encourage best practices to get us ready for typing. If I had to guess on another big next task it would probably be to include type annotations with galaxy-util, galaxy-tool-util, and bioblend. I had to disable import checking because a variety of libraries don't support it - so starting at the bottom of the dependency chain and working up would probably be the next step?

@jmchilton jmchilton merged commit 4b9b1a5 into galaxyproject:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants