Skip to content

Implement stubs for outputs#1051

Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom
mvdbeek:fill_outputs
Aug 3, 2020
Merged

Implement stubs for outputs#1051
jmchilton merged 1 commit intogalaxyproject:masterfrom
mvdbeek:fill_outputs

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 3, 2020

Would be awesome if we could figure out the class (File, Collection,
Parameter) and more details about each, but that seems like more than we
can do without having the tools available.

Would be awesome if we could figure out the class (File, Collection,
Parameter) and more details about each, but that seems like more than we
can do without having the tools available.
@jmchilton jmchilton merged commit 6b8b0a3 into galaxyproject:master Aug 3, 2020
@jmchilton
Copy link
Member

I suspect if you think this is a good idea, you're right and this is probably the right thing to do - there was a weird psychology thing that held me back. I think if people have to delete a line because they don't have a test for a particular output they will feel like ... we're judging them and they're doing something against best practices - and so workflow testing will feel heavier than it needs to be. I was thinking if they were commented out lines people would feel empowered as they added tests for each output they wanted to instead of defeated as they removed tests they couldn't right. I was planning to take another pass where I did that - maybe by treating the file as text and adding comments hackily or using ruamel and adding comment objects. Would you object to me doing that on top of this?

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 3, 2020

Absolutely no objection, I also wanted to do this, but as you noticed it's either hacky or we need to invest a bit more effort to nicely embed comments in the dumped yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants