Merged
Conversation
4aa68c2 to
f5f0a6d
Compare
jmchilton
commented
Jul 17, 2020
5d707e3 to
cb606ed
Compare
mvdbeek
reviewed
Jul 20, 2020
Member
Author
|
At very least progress - I wonder if this is toolshed problems or gunicorn not having request lengths that are long enough 😅 |
Member
Author
|
The gap there is exactly the default so probably not a toolshed problem. |
Merged
bgruening
reviewed
Jul 21, 2020
| shell(["ps", "ax"]) | ||
| exists = os.path.exists(self.pid_file) | ||
| print("Killing pid file [%s]" % self.pid_file) | ||
| print("pid_file exists? [%s]" % exists) |
Member
There was a problem hiding this comment.
I think this should be removed before merging.
Member
Author
There was a problem hiding this comment.
It is all hidden behind the verbose flag though?
| except Exception: | ||
| if ctx.verbose: | ||
| io.shell(['ls', config.galaxy_root]) | ||
| print("Failed to install tool repositories, Galaxy log:") |
17b8490 to
c148855
Compare
- Use pytest. - Rework tox to add more bells and whistles. - Skip more client building when not needed - slows down the tests a lot it seems. - More debugging in various places - in tests and in app. - Fix options in shed_serve. - Various gunicorn fixes. - Rework some testing framework to use concurrent.futures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #945 .
Redo testing.
Also change directory for gx_venv because it doesn't default to Python 2 anymore.