Skip to content

[training] add shared data library path to the data upload box#1013

Merged
nsoranzo merged 11 commits intogalaxyproject:masterfrom
shiltemann:training-datalib
Jun 4, 2020
Merged

[training] add shared data library path to the data upload box#1013
nsoranzo merged 11 commits intogalaxyproject:masterfrom
shiltemann:training-datalib

Conversation

@shiltemann
Copy link
Member

ping @bebatut

@nsoranzo nsoranzo force-pushed the training-datalib branch from 43a400c to 7e9cd0a Compare June 4, 2020 17:10
@nsoranzo
Copy link
Member

nsoranzo commented Jun 4, 2020

@jmchilton @mvdbeek Any idea what can cause this failure to install tools under Python3: https://github.com/galaxyproject/planemo/pull/1013/checks?check_run_id=739406576#step:7:3979

I can reproduce it locally with tox -e py36-unit tests/test_training_tutorial.py:test_get_hands_on_boxes_from_local_galaxy

@jmchilton
Copy link
Member

xref #1005 - I've looked at it but I didn't make much progress. My guess was something like Galaxy is still running under Python 2 and there being some conflict between the versions. I don't know though.

@nsoranzo
Copy link
Member

nsoranzo commented Jun 4, 2020

I don't see any trace of Python 2 in my local log and the hg in the linked error is installed in a python3.6 virtualenv. If I activate that virtualenv and execute e.g. hg clone -r 16 https://toolshed.g2.bx.psu.edu/repos/devteam/fastqc /tmp/tmpm19uvucu/shed_tools/toolshed.g2.bx.psu.edu/repos/devteam/fastqc/ff9530579d1f/fastqc it works fine.

For now I'll merge this.

@nsoranzo nsoranzo merged commit 3af42a0 into galaxyproject:master Jun 4, 2020
@nsoranzo
Copy link
Member

nsoranzo commented Jun 4, 2020

Thanks @shiltemann and sorry for abusing your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants