More fine grained options for --shed_install#1001
Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom Mar 13, 2020
Merged
More fine grained options for --shed_install#1001jmchilton merged 1 commit intogalaxyproject:masterfrom
jmchilton merged 1 commit intogalaxyproject:masterfrom
Conversation
Contributor
Author
|
cc @bgruening |
Member
|
@AndreasSko a few tests are failing, can you please look at those? |
Contributor
Author
Seems strange.. |
`--shed_install` uses the default options for installing tools from Ephemeris, resulting in automatic dependency resolution/installation on first run (see: https://github.com/galaxyproject/ephemeris/blob/6a01ac3de3f8e40145365523e3ae8807b9072282/src/ephemeris/shed_tools.py#L103). In some situations, where installing dependencies is not necessary (for example when using containers), disabling this would result in faster execution time. With this change, the options `--install_tool_dependencies`, `--install_resolver_dependencies`, and `--install_repository_dependencies` are introduced, which enables to define tool installation using `--shed_install` more fine grained. The default options stay the same, so there should be no breaking change to existing usage.
2dff5b3 to
d871c03
Compare
Contributor
Author
|
Is it possible that the tests/pipeline itself is broken currently? Tested the master branch on my fork and it failed with the same problem: https://github.com/AndreasSko/planemo/actions/runs/53662366 |
Member
|
Those look like pre-existing problems - thanks for the enhancements! They look great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--shed_installuses the default options for installing tools from Ephemeris, resulting in automatic dependency resolution/installation on first run (see: https://github.com/galaxyproject/ephemeris/blob/6a01ac3de3f8e40145365523e3ae8807b9072282/src/ephemeris/shed_tools.py#L103). In some situations, where installing dependencies is not necessary (for example when using containers), disabling this would result in faster execution time.With this change, the options
--install_tool_dependencies,--install_resolver_dependencies, and--install_repository_dependenciesare introduced, which enables to define tool installation using--shed_installmore fine grained. The default options stay the same, so there should be no breaking change to existing usage.