Skip to content

shed_upload should print better error message if repository doesn't exist #198

@peterjc

Description

@peterjc

This repository does not yet exist: https://testtoolshed.g2.bx.psu.edu/view/peterjc/fastq_pair_names

Using my fastq_pair_names tool https://github.com/peterjc/pico_galaxy/tree/master/tools/fastq_pair_names from this repository as of this commit: peterjc/pico_galaxy@eb6b8e6

According to planemo shed_lint things look OK:

$ planemo shed_lint ~/repositories/pico_galaxy/tools/fastq_pair_names/
Linting repository /mnt/galaxy/repositories/pico_galaxy/tools/fastq_pair_names
Applying linter expansion... CHECK
.. INFO: Included files all found.
Applying linter tool_dependencies_xsd... CHECK
.. INFO: No tool_dependencies.xml, skipping.
Applying linter tool_dependencies_actions... CHECK
.. INFO: No tool_dependencies.xml, skipping.
Applying linter repository_dependencies... CHECK
.. INFO: No repository_dependencies.xml, skipping.
Applying linter shed_yaml... CHECK
.. INFO: .shed.yml found and appears to be valid YAML.
Applying linter readme... CHECK
.. INFO: README found containing valid reStructuredText.

However, the planemo shed_upload does not seem to create the repository - it fails (return code 255) but does not give any error message:

$ planemo shed_upload --shed_target testtoolshed ~/repositories/pico_galaxy/tools/fastq_pair_names/ ; echo "$? returned"
cd '/mnt/galaxy/repositories/pico_galaxy/tools/fastq_pair_names' && git rev-parse HEAD
cd '/mnt/galaxy/repositories/pico_galaxy/tools/fastq_pair_names' && git diff --quiet
/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/requests-2.7.0-py2.6.egg/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/mnt/galaxy/repositories/planemo/.venv/lib/python2.6/site-packages/requests-2.7.0-py2.6.egg/requests/packages/urllib3/connectionpool.py:768: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
255 returned

(The insecure warnings occur on other operations and seem to be harmless)

Using planemo as of 52b0725 (start of work on v0.12.0)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions