Skip to content

shed_upload silent if missing .shed.yml include files #158

@peterjc

Description

@peterjc

My reading of the code suggests that the default include value is ** (all files next to the .shed.yml file). I have tried adding an explicit listing of files, e.g.

$ more ~/repositories/pico_galaxy/tools/venn_list/.shed.yml
name: venn_list
owner: peterjc
homepage_url: https://github.com/peterjc/pico_galaxy/tools/venn_list
remote_repository_url: https://github.com/peterjc/pico_galaxy/tools/venn_list
description: Draw Venn Diagram (PDF) from lists, FASTA files, etc
long_description: |
  Draw Venn Diagrams for 1, 2 or 3 sets of identifiers as a PDF file.

  Can parse FASTA, FASTQ, SFF or tabular files (taking column one) for identifiers.
  This can be combined with the extensive tabular file filtering and manipulation
  tools within Galaxy to prepare the input data.

  Uses the R/Bioconductor package limma to draw the PDF file, called from Python with
  rpy.

  Uses Biopython to parse SFF files.
categories:
- Graphics
- Sequence Analysis
- Visualization
type: unrestricted
include:
- README.rst
- venn_list_with_typo.py
- venn_list.xml
- tool_dependencies.xml

This fails to complain about missing venn_list_with_typo.py:

$ planemo shed_upload --tar_only  ~/repositories/pico_galaxy/tools/venn_list 
cp /tmp/tmpx0zfjB shed_upload.tar.gz
$ tar -tzf /tmp/tmpx0zfjB
tool_dependencies.xml
README.rst
venn_list.xml

On the positive side, it did not include venn_list.py because it wasn't asked to (deliberate mismatch with venn_list_with_typo.py).

I want this example to fail, complaining that venn_list_with_typo.py was listed in the includes, but not found. Ideally the error would list all named but missing files, but just the first missing file would be acceptable.

As an aside, would checking the include files exist also fall under planemo lint functionality for validating the .shed.yml?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions