Improve variant calling from ampliconic PE data#33
Merged
mvdbeek merged 6 commits intogalaxyproject:mainfrom Jun 5, 2021
Merged
Improve variant calling from ampliconic PE data#33mvdbeek merged 6 commits intogalaxyproject:mainfrom
mvdbeek merged 6 commits intogalaxyproject:mainfrom
Conversation
Fixes weaknesses of the previous workflow discovered from COG-UK tracking effort results on usegalaxy.* instances and from comparison to https://www.veo-europe.eu/ results for the same data.
Otherwise tabular files with variable number of columns are sniffed as txt files.
mvdbeek
reviewed
Jun 4, 2021
| --------- | ||
| # Changelog | ||
|
|
||
| ## [0.3] - 2021-05-19 |
Member
There was a problem hiding this comment.
The ---- is need to delineate entries for the release text.
Member
There was a problem hiding this comment.
... which was broken in planemo, but we should keep the formatting.
Member
There was a problem hiding this comment.
fwiw, this was the idea:
In [12]: def changelog_in_repo(target_repository_path):
...: changelog = []
...: for path in os.listdir(target_repository_path):
...: if 'changelog.md' in path.lower():
...: header_seen = False
...: header_chars = ('---', '===', '~~~')
...: with(open(os.path.join(target_repository_path, path))) as changelog_fh:
...: for line in changelog_fh:
...: if line.startswith(header_chars):
...: if header_seen:
...: return "\n".join(changelog[:-1])
...: else:
...: header_seen = True
...: changelog.append(line.rstrip())
...: return "\n".join(changelog)
...:
In [13]: print(changelog_in_repo('workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling/'))
0.3
---
This version brings a number of tweaks to the ivar-dependent steps of the
workflow. Together, these are expected to make variant allele frequency
calculations more precise, in general, and robust in the face of an increasing
number of variants at primer binding sites:
- Upgrade ivar from version 1.2.2 to 1.3.1
This affects ivar trim and ivar removereads
- Use the newly introduced -f option of ivar trim to exclude read pairs from
further analysis that extend beyond amplicon boundaries.
This change should be benefitial for accurate AF calculations in general,
but in particular for corrected AF values after removal of biased amplicons,
where aberrant read pairs often represent a larger fraction of the remaining
reads.
- Run ivar trim only after realignment and addition of indel qualities by
lofeq. This should make sure that indels close to primer sequences are
seen as read-internal events.
- Turn the lower and upper thresholds for variant AF that triggers readremoval
into workflow input parameters and adjust their defaults to trigger read
removal only in more obvious cases of non-fixed variants.
- Require a minimum depth of coverage for recalled variants after read removal
of 20 to ensure reliable AF values.
This change also prevents situations where variants are recalled successfully
after read removal, but are later excluded from variant reports generated by
the reporting workflow due to that workflow's min_dp_alt >= 10 filter.
Member
There was a problem hiding this comment.
Okay, let's follow https://keepachangelog.com/en/0.3.0/ ... I will update the function that didn't work in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes weaknesses of the previous workflow discovered from COG-UK
tracking effort results on usegalaxy.* instances and from comparison to
https://www.veo-europe.eu/ results for the same data.