Merged
Conversation
f60de8e to
e3f8c16
Compare
mvdbeek
reviewed
Sep 21, 2023
workflows/VGP-assembly-v2/VGP-WF3-Assembly/test-data/Estimated Genome size.expression.json
Outdated
Show resolved
Hide resolved
Member
|
Can you rename the workflow and folder to something more descriptive ? e.g. VGP-hifiasm-assembly or VGP-hifiasm-assembly-pacbio-only or something like this ? |
mvdbeek
reviewed
Sep 21, 2023
workflows/VGP-assembly-v2/VGP-WF3-Assembly/Assembly-(WF3)-tests.yml
Outdated
Show resolved
Hide resolved
Member
|
mvdbeek
reviewed
Sep 27, 2023
workflows/VGP-assembly-v2/Assembly-Hifi-only-VGP3/Assembly-Hifi-only-VGP3-tests.yml
Outdated
Show resolved
Hide resolved
056fc49 to
ad6dd49
Compare
mvdbeek
approved these changes
Oct 19, 2023
Member
mvdbeek
left a comment
There was a problem hiding this comment.
I think the README could be a little better, but we can still iterate on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the workflow to perform the genome Assembly in solo mode (WF3 in the VGP-Galaxy workflow suite)